CONTRIBUTING: fix a few typos and a minor rewording #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a bit nitpicky but moving the "you" into the actual statements makes those a stronger statement than otherwise. Plus add commas to make sure this is read as list and not either/or statements.
Hah, separate logical changes so you did right. :) |
zeenix
approved these changes
Aug 10, 2023
|
Since |
|
Does the "Assert auto traits on item" section apply to busd as well? Or do I leave that out? The rest is a straightforward copy. |
Actually, no. We only do that in zbus to avoid breaking public API. Good catch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please feel free to squash these together, I have no preferences here.